Skip to content

Group commandline tests in a directory #90560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Group commandline tests in a directory #90560

wants to merge 1 commit into from

Conversation

vandenheuvel
Copy link
Contributor

@vandenheuvel vandenheuvel commented Nov 4, 2021 •
edited
Loading

I grouped the ui/command* tests in ui/command/argfile/ and rustdoc-ui/command* in rustdoc-ui/commandline-argfile/.

@jyn514
Copy link
Member

jyn514 commented Nov 4, 2021

@vandenheuvel please do not remove the rustdoc tests. They test the behavior of rustdoc, not rustc, and we've had regressions where the behavior differs before.

@vandenheuvel vandenheuvel force-pushed the commandline_argfile_tests branch from 53af261 to 27893dd Compare November 4, 2021 14:47
@vandenheuvel
Copy link
Contributor Author

r? @jyn514

@jyn514
Copy link
Member

jyn514 commented Nov 4, 2021

I don't have time to review this right now, sorry.

r? rust-lang/compiler

@rust-highfive rust-highfive assigned jackh726 and unassigned jyn514 Nov 4, 2021
@vandenheuvel
Copy link
Contributor Author

@rustbot label: +S-waiting-on-review

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 8, 2021
@vandenheuvel
Copy link
Contributor Author

r? rust-lang/compiler

@vandenheuvel vandenheuvel mentioned this pull request Nov 10, 2021
Closed
@jyn514
Copy link
Member

jyn514 commented Nov 10, 2021

@vandenheuvel please don't reassign people after only a couple days, it can be a while before they have time to review and switching often actually makes it less likely.

@jyn514 jyn514 assigned jackh726 and unassigned wesleywiser Nov 10, 2021
@apiraino apiraino added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Nov 11, 2021
@wesleywiser
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 13, 2021

📌 Commit 27893dd has been approved by wesleywiser

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2021
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 13, 2021
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 13, 2021
@matthiaskrgr
Rollup merge of rust-lang#90560 - vandenheuvel:commandline_argfile_te…
5f0cd0a 
…sts, r=wesleywiser

Group commandline tests in a directory

I grouped the `ui/command*` tests in `ui/command/argfile/` and `rustdoc-ui/command*` in `rustdoc-ui/commandline-argfile/`.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 13, 2021
@matthiaskrgr
Rollup merge of rust-lang#90560 - vandenheuvel:commandline_argfile_te…
f26d7e1 
…sts, r=wesleywiser

Group commandline tests in a directory

I grouped the `ui/command*` tests in `ui/command/argfile/` and `rustdoc-ui/command*` in `rustdoc-ui/commandline-argfile/`.
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 13, 2021
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 13, 2021
@matthiaskrgr
Rollup merge of rust-lang#90560 - vandenheuvel:commandline_argfile_te…
c4e0b8b 
…sts, r=wesleywiser

Group commandline tests in a directory

I grouped the `ui/command*` tests in `ui/command/argfile/` and `rustdoc-ui/command*` in `rustdoc-ui/commandline-argfile/`.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 13, 2021
@matthiaskrgr
Rollup merge of rust-lang#90560 - vandenheuvel:commandline_argfile_te…
0576445 
…sts, r=wesleywiser

Group commandline tests in a directory

I grouped the `ui/command*` tests in `ui/command/argfile/` and `rustdoc-ui/command*` in `rustdoc-ui/commandline-argfile/`.
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 13, 2021
Closed
@bors
Copy link
Collaborator

bors commented Nov 14, 2021

⌛ Testing commit 27893dd with merge 6e4d0c0ea48ac97ee508ed6dacd490695fc3482e...

@bors
Copy link
Collaborator

bors commented Nov 14, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 14, 2021
@rust-log-analyzer
Copy link
Collaborator

The job dist-mips64-linux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
[RUSTC-TIMING] rustc_std_workspace_std test:false 0.047
   Compiling getopts v0.2.21
[RUSTC-TIMING] unicode_width test:false 0.069
[RUSTC-TIMING] proc_macro test:false 0.164
rustc exited with signal: 6 (core dumped)
error: could not compile `proc_macro`
Caused by:
Caused by:
  process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name proc_macro --edition=2018 library/proc_macro/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi --crate-type lib --emit=dep-info,metadata,link -C opt-level=3 -C embed-bitcode=no -C codegen-units=1 -C debuginfo=1 -C metadata=5c4876908862739f -C extra-filename=-5c4876908862739f --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/release/deps --extern std=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/x86_64-unknown-linux-gnu/release/deps/libstd-c4fe96599cfce917.so --extern std=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/x86_64-unknown-linux-gnu/release/deps/libstd-c4fe96599cfce917.rlib --cfg=bootstrap -Zsymbol-mangling-version=legacy -Zmacro-backtrace '-Clink-args=-Wl,-rpath,$ORIGIN/../lib' -Cprefer-dynamic '-Zcrate-attr=doc(html_root_url="https://doc.rust-lang.org/nightly/")' -Z binary-dep-depinfo -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/x86_64-unknown-linux-gnu/release/build/compiler_builtins-399cb2af88d0d65a/out` (exit status: 254)
[RUSTC-TIMING] getopts test:false 1.844
error: build failed
Build completed unsuccessfully in 0:00:40

@petrochenkov petrochenkov mentioned this pull request Nov 14, 2021
Merged
@vandenheuvel
Copy link
Contributor Author

I think this should still be good to merge, as these were removed from #90837.

@jackh726
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2021
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Nov 15, 2021
@workingjubilee
Rollup merge of rust-lang#90560 - vandenheuvel:commandline_argfile_te…
bf57fec 
…sts, r=wesleywiser

Group commandline tests in a directory

I grouped the `ui/command*` tests in `ui/command/argfile/` and `rustdoc-ui/command*` in `rustdoc-ui/commandline-argfile/`.
@workingjubilee workingjubilee mentioned this pull request Nov 15, 2021
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 15, 2021
@matthiaskrgr
Rollup merge of rust-lang#90560 - vandenheuvel:commandline_argfile_te…
58d8d39 
…sts, r=wesleywiser

Group commandline tests in a directory

I grouped the `ui/command*` tests in `ui/command/argfile/` and `rustdoc-ui/command*` in `rustdoc-ui/commandline-argfile/`.
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 15, 2021
Closed
@matthiaskrgr
Copy link
Member

Looks like this failed in a rollup:
#90923 (comment)
@bors r- rollup=iffy

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 15, 2021
@jyn514 jyn514 added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 18, 2021
@JohnCSimon
Copy link
Member

Ping from triage:
@vandenheuvel Can you please post the status of this PR?

@vandenheuvel
Copy link
Contributor Author

@JohnCSimon I think this can be merged. Can this be retried once more?

@jyn514
Copy link
Member

jyn514 commented Dec 12, 2021

@vandenheuvel the test failure was real, $DIR doesn't work on Windows unfortunately

failures:

---- [ui] ui\command\argfile\commandline-argfile-badutf8.rs stdout ----


- error: Failed to load argument file: Utf8 error in $DIR/commandline-argfile-badutf8.args
+ error: Failed to load argument file: Utf8 error in D:\a\rust\rust\src/test\ui/command/argfile/commandline-argfile-badutf8.args
3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@jackh726 jackh726

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@vandenheuvel @jyn514 @wesleywiser @bors @rust-log-analyzer @jackh726 @matthiaskrgr @JohnCSimon @apiraino @rustbot